Conversation
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
luoluoyuyu
left a comment
luoluoyuyu
left a comment
There was a problem hiding this comment.
Review summary
Handles transient InconsistentDataException during async load when show databases is briefly inconsistent across DataNodes. Retry loop structure and Thread.currentThread().interrupt() on InterruptedException are correct.
Looks good to merge.
| break; | ||
| } | ||
| } | ||
| } catch (InconsistentDataException ignored) { |
There was a problem hiding this comment.
Catching InconsistentDataException and retrying is appropriate for this async load scenario. Optional: if all 10 retries fail, consider mentioning retry count in the final assertion message to simplify debugging. Not blocking.
2 participants
Description
As the title said.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR